Mark make_ascii_uppercase and make_ascii_lowercase in [u8] and str as const.
#130738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@rustbot label +T-libs-api -T-libs r? libs-api |
rustbot
added
T-libs-api
5 tasks
bjoernager
force-pushed
the
const-make-ascii
branch
from
bf3dcd4
to
583862e
Compare
bjoernager
force-pushed
the
const-make-ascii
branch
from
583862e
to
2daf076
Compare
|
|
bjoernager
force-pushed
the
const-make-ascii
branch
from
bf3dcd4
to
74a7797
Compare
jhpratt
reviewed
Sep 24, 2024
…in '[u8]' and 'str' as const;
bjoernager
force-pushed
the
const-make-ascii
branch
from
74a7797
to
e723fe1
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (11e760b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 0.3%, secondary -1.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 768.999s -> 770.84s (0.24%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant tracking issue: #130698
This PR extends #130697 and #130713 to the similar methods in byte slices (
[u8]) and string slices (str).For the
strmethods, this simply requires adding theconstspecifier to the function signatures. The[u8]methods, however, require (at least a temporary) reimplementation due to the use of iterators andforloops.